Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stop chuck norris image from displaying behind other charts #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thomasbehan
Copy link

No description provided.

@batmat batmat closed this Jul 19, 2019
@batmat
Copy link
Member

batmat commented Jul 19, 2019

Can you please provide some screenshot showing the issue before and after the fix?
Thanks!

@batmat batmat reopened this Jul 19, 2019
@Thomasbehan
Copy link
Author

Hi here is the screenshot for before the fix
image
had to scribble some stuff out
the issue was solved by placing the image in its own container with some responsive css added which results in the following image
image
it appears next to the graphs and not behind them
Let me know if you need anything else :)

@Thomasbehan
Copy link
Author

Any joy with this one being merged plz? :)

@batmat batmat closed this Aug 16, 2019
@batmat batmat reopened this Aug 16, 2019
@Thomasbehan
Copy link
Author

Can one of you guys advise on how to get this merged in?

@oleg-nenashev
Copy link
Member

CC @jenkinsci/code-reviewers

Copy link

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
You may need to close and reopen to kick off the CI job again

@oleg-nenashev
Copy link
Member

It looks to be a real test failure, not 100% sure.

Error
unexpected build status; build log was:
------
Started
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] Start of Pipeline
[Pipeline] chuckNorris
Submitting to Chuck's will
[Pipeline] semaphore
------
Expected: is <FAILURE>
     but: was null
Stacktrace
java.lang.AssertionError: 
unexpected build status; build log was:
------
Started
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] Start of Pipeline
[Pipeline] chuckNorris
Submitting to Chuck's will
[Pipeline] semaphore
------
Expected: is <FAILURE>
     but: was null
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:964)
	at org.jvnet.hudson.test.JenkinsRule.assertBuildStatus(JenkinsRule.java:1377)
	at hudson.plugins.chucknorris.pipeline.ChuckNorrisStepTest$4.evaluate(ChuckNorrisStepTest.java:119)
	at org.jvnet.hudson.test.RestartableJenkinsRule$6.evaluate(RestartableJenkinsRule.java:291)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:599)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)
Standard Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants