Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include warnings-ng reports in templates #499

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Include warnings-ng reports in templates #499

merged 1 commit into from
Jan 16, 2024

Conversation

strangelookingnerd
Copy link
Contributor

From personal experience I think it makes sense to include the reports from warnings-ng in the emails send by Jenkins. I know that one can customize the templates as desired but I'd love to see this added as a recommendation.

I added the reports only to the currently documented templates and left the other untouched.
Regarding the code-formatting: It is a mess already and I did not bother - let me know if you want me to change it.

See the screenshots below that demonstrate the feature:

groovy-html.template
groovy-html.template

groovy-text.template
groovy-text.template

html.jelly
html.jelly

text.jelly
text.jelly

Testing done

Existing tests run fine. Manually tested visual changes are as intended - see screenshots for details.

Submitter checklist

Preview Give feedback

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 16, 2024 13:42
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for the PR!

@basil basil added the rfe label Jan 16, 2024
@basil basil merged commit 258cb56 into jenkinsci:master Jan 16, 2024
16 checks passed
@strangelookingnerd strangelookingnerd deleted the feature/include_warnings_ng branch March 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants