Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase spotbugs checks #1475

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Increase spotbugs checks #1475

merged 4 commits into from
Jul 1, 2023

Conversation

MarkEWaite
Copy link
Contributor

Increase spotbugs checks

Increases spotbugs checks by reducing the threshold to "Low". Also resolves a few spotbugs warnings by code corrections.

  • Remove uncalled static method
  • Remove redundant null checks in AbstractGitSCMSource
  • Fix spotbugs warning on repo cache size updates
  • Increase spotbugs checks

Inspired by a NonNull annotation in #1468 that should have reported a spotbugs warning and did not.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Dependency or infrastructure update

MarkEWaite added 4 commits July 1, 2023 12:52
@MarkEWaite
Remove uncalled static method
0ea123a
@MarkEWaite
Remove redundant null checks in AbstractGitSCMSource
4987109
@MarkEWaite
Fix spotbugs warning on repo cache size updates
2931c16 
Spotbugs correctly reported a race condition where the check for
insertion of a value might report the value is missing then another
thread inserted the value before the current thread performed the
`put`.  Simpler to `put` the value every time the method is called and
then check for the rare case when the value that was put is smaller
than the value that was there perviously.

Repository size cache is used as a hint.  Errors in the size cache may
lead to suboptimal choices temporarily, but they should not lead to
incorrect behavior.
@MarkEWaite
Increase spotbugs checks
840c410 
Add spotbugs exclusions reported as part of the increased checks.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jul 1, 2023
@github-actions github-actions bot added the dependencies Dependency related change label Jul 1, 2023
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Jul 1, 2023
@MarkEWaite MarkEWaite enabled auto-merge (rebase) July 1, 2023 20:01
@MarkEWaite MarkEWaite merged commit bfeca7f into jenkinsci:master Jul 1, 2023
@MarkEWaite MarkEWaite deleted the increase-spotbugs-checks branch July 1, 2023 20:59
@MarkEWaite MarkEWaite mentioned this pull request Jul 1, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite