Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL #1642

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 23, 2024

[JENKINS-73676] Allow users with Job/CONFIGURE permission to edit remote URL

Changes for FIPS mistakenly placed the requirement for administrator on the field when it previously allowed users with Job/CONFIGURE permission to modify the field.

Testing done

Duplicated JENKINS-73676 by installing Jenkins 2.473 with the role strategy plugin. Configured three users:

  • mwaite - Administrator
  • a-developer - User with modify permission on jobs and credentials
  • a-reader - User with only read permissions

Created a fine-grained personal access token for one of my private GitHub repositories and confirmed that the repository could be read with that credential and could not be read without that credential.

Created the 'Developer-role' and assigned 'a-developer' to the role. Created the 'Reader-role' and assigned 'a-reader' to the role.

Confirmed that the 'mwaite' user could modify the URL of the remote repository before and after this change.

Confirmed that without this change, the 'a-developer' user is shown the job configuration form but sees a stack trace in the console and errors on the web page.

Confirmed that with this change, the 'a-developer' user is shown the job configuration form and is allowed to modify the URL of the remote repository.

Confirmed that the 'a-reader' user cannot see the editing form.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…ote URL

Changes for FIPS mistakenly placed the requirement for administrator on
the field when it previously allowed users with Job/CONFIGURE permission
to modify the field.
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Aug 23, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 23, 2024 00:14
@MarkEWaite MarkEWaite requested a review from olamy August 23, 2024 00:14
@MarkEWaite MarkEWaite merged commit e015312 into jenkinsci:master Aug 23, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the check-item-configure-permission branch August 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or flawed behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants