Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73134] Adapt github-oauth-plugin for jetty 12 (EE8) #267

Merged
merged 6 commits into from
Aug 19, 2024
Merged

[JENKINS-73134] Adapt github-oauth-plugin for jetty 12 (EE8) #267

merged 6 commits into from
Aug 19, 2024

Conversation

BorisYaoA
Copy link
Contributor

@BorisYaoA BorisYaoA commented Aug 7, 2024 •
edited
Loading

see https://issues.jenkins.io/browse/JENKINS-73134

The goal is to adapt the plugin for jetty 12.
The PR is on hold until JENKINS-73130 is merged and released.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

BorisYaoA and others added 6 commits August 7, 2024 16:03
@BorisYaoA
[JENKINS-73134] Adapt github-oauth-plugin for jetty12
526cbea
@BorisYaoA
change jenkins version
d921d0e
@BorisYaoA
revert jenkins version
29ce868
@MarkEWaite
Merge branch 'master' into Adapt_github_oauth_plugin_for_jetty12
077bd56
@MarkEWaite
Require Jenkins 2.472 as minimum Jenkins version
c2bde22 
Jetty 12 EE 8 dependencies in the tests require Jenkins 2.472 or newer.

Use plugin BOM 2.462.x as the most recent plugin BOM.  Once 2.472 is
available in an LTS, then the plugin BOM that includes Jenkins 2.472
can be used as well.
@MarkEWaite
Test with Jenkins test harness 2254.x
fa3c9c5 
Most recent Jenkins test harness
@BorisYaoA BorisYaoA marked this pull request as ready for review August 19, 2024 08:25
@BorisYaoA BorisYaoA requested a review from a team as a code owner August 19, 2024 08:25
MarkEWaite
MarkEWaite approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the enhancement A new feature label Aug 19, 2024
@MarkEWaite MarkEWaite merged commit 70d151e into jenkinsci:master Aug 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BorisYaoA @MarkEWaite