Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape illegal '.' character before submitting data to ElasticSearch. #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ceilfors
Copy link
Member

@ceilfors ceilfors commented Jan 5, 2017

ElasticSearch is rejecting logstash-plugin data when an environment variable contains a '.' character. Specific problem encountered: When artifactory-plugin is used, the plugin will inject an environment variable called buildInfoConfig.propertiesFile.

ElasticSearch is rejecting logstash-plugin data when an environment variable contains a '.' character. Specific problem encountered: When artifactory-plugin is used, the plugin will inject an environment variable called buildInfoConfig.propertiesFile.
@jakub-bochenski
Copy link

jakub-bochenski commented May 10, 2017

@ceilfors I tried to reproduce the issue with 1.2.1, but I can't

I've set VARIABLE.WITH.DOT via EnvInject and I see an

"_source": {
  "data":  {
    "buildVariables": {
        "VARIABLE.WITH.DOT": "foo",

entry in ES

@ceilfors
Copy link
Member Author

ceilfors commented May 10, 2017 via email

@jakub-bochenski
Copy link

I think it worked in my setup because I'm actually using Logstash before the ES instance with the de_dot filter: https://www.elastic.co/blog/introducing-the-de_dot-filter

I think this is another reason for having a separate ES and Logstash indexer types instead of using the same for both

@jakub-bochenski jakub-bochenski mentioned this pull request Jul 3, 2017
@jakub-bochenski
Copy link

@mwinter69 I think we should add this to the logstash tcp backed? I don't think it was included in #59

@mwinter69
Copy link

No, but this PR here is for Elastic Search. I think it should be optional.

@jakub-bochenski
Copy link

uh, right sorry I mixed the two up

@mwinter69 mwinter69 mentioned this pull request Jul 5, 2018
@darxriggs
Copy link

Should this be closed as the author already moved on to other projects?

@jakub-bochenski
Copy link

The OP might have moved on, but the problem is still there. The challenge is to handle it while keeping it opt-in and without code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants