Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter and default override for expired/not found images #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yrainik-godaddy
Copy link

Resolve: #286

This change allow users to provide name filter(based on Java regexp), that will show only matched names in config. That is helpful for organizations that have many different OS images. Also introducing override provided name, if image was deprecated/removed from available list, first matched by filter will be selected, that helps prevent downtime when organizations do image rotations, and don't need to go to each jenkins and update image name.

All BootSources are supported, except Unspecified.

UI Changes:
Screen Shot 2020-09-27 at 11 37 16 AM

@yrainik-godaddy yrainik-godaddy marked this pull request as ready for review September 27, 2020 19:11
@yrainik-godaddy
Copy link
Author

Hi @olivergondza! Could you review PR?

@olivergondza
Copy link
Member

Thanks for your contribution.

What is the motivation to use images/volumes with different names for image rotation? The plugin supports the use-case for ages by selecting the newest image of given name. So the image rotation can be implemented provided the images are replaced with images of the same name.

I am pushing on the side of simplicity here to keep the number of controls minimal.

@yrainik-godaddy
Copy link
Author

Hi @olivergondza, thank you for quick response. Intention of images with different names, is that our openstack team allow teams to migrate to newest approved image, and if something went wrong with compatibility, you don't have to immediately find a way how to fix it(which will stop CI/CD pipelines in our case).

To keep number of controls minimal, do you think plugin will support extensions or experimental flag(allow more controls) sometime soon? That will allow 3rd party devs to make reusable changes and don't just fork plugin and made changes.

@olivergondza
Copy link
Member

Intention of images with different names, is that our openstack team allow teams to migrate to newest approved image, and if something went wrong with compatibility, you don't have to immediately find a way how to fix it(which will stop CI/CD pipelines in our case).

Yeah, that all is possible by using images with the same name. You can have number of them co-existing, plugin will pick up the latest, and if you find the latest one problematic, you can rename/remove it to effectively move back to the latest working one.

To keep number of controls minimal, do you think plugin will support extensions or experimental flag(allow more controls) sometime soon? That will allow 3rd party devs to make reusable changes and don't just fork plugin and made changes.

That is definitely something I would like to avoid, both of that. Let me understand your use-case, and see what is the least intrusive way to get you going...

@yrainik-godaddy
Copy link
Author

you can rename/remove it to effectively move back to the latest working one.

The problem is, that i'm not part of openstack image managing team, and most likely name format will not change. Image name format is centos-, and they rotate every month/weeks depends on patching. Could get list of names been automated via dsl call? I could create a job to check list of names and update it in config

@olivergondza
Copy link
Member

@yrainik-godaddy, I see. How about extending the semantics of the current field that accept id or name to accept regexp as well? It will potentially match multiple images of same/alike names, and it would use the newest as it currently does?

@yrainik-godaddy
Copy link
Author

That will work, need to figure our how to combine textbox with select for UI. Still will require filtering all images on plugin side, as i read OpenStack api documentation, filter accepts only full match string, which will not work for RegExp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Name by Regex
2 participants