Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cleanup and pre-creation recurrence period configurable #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZbigniewZabost
Copy link

@ZbigniewZabost ZbigniewZabost commented Oct 6, 2022

This PR allows Jenkins operator to configure the recurrence period for cleanup and pre-creation threads.

This allows to faster cleanup and pre-creating machines, I find this setting particular useful in scenario where openstack agents are single-use (1 executor, 0 retention time) and combined with set of quick jobs (less than 1 minute or so) that are often executed. It may lead to situation when openstack plugin is not able to create new machines due to hitting limit but at the same time the already existing machines are marked for termination filling up quota. In worst case almost 10 min to get cleanup and freed up limit.

Implementation has been inspired by same issue in ec2 jenkins plugin

This PR relates to #282

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@steveames
Copy link

This would be pretty useful. Even if the jobs aren't short, when the build queue gets longer it's painful to wait 10 minutes for a VM to get removed.

@matigoal
Copy link

Hello,

Will this pull request be merged in the next releases?

Have a great day.

@simonelbaz
Copy link

Hi,

is there any reason why this PR is not merged ?
I am ready to help if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants