Merge pull request #13 from jenkinsci/12-fix-code-scanning-alert-stap…

…ler-missing-permission-check Resolved issue by adding permission check
jenkinsci · Jun 14, 2023 · 193783b · 193783b
2 parents b1e3880 + d0b4774
commit 193783b
Showing 1 changed file with 25 additions and 2 deletions.
diff --git a/src/main/java/io/jenkins/plugins/ProvarAutomation.java b/src/main/java/io/jenkins/plugins/ProvarAutomation.java
@@ -376,13 +376,19 @@ public void setInstallations(ProvarAutomationInstallation... provarAutomationIns
 
  public FormValidation doCheckBuildFile(@QueryParameter String value)
  throws IOException, ServletException {
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return FormValidation.ok();
+ }
  if (value.length() == 0)
  return FormValidation.warning(Messages.ProvarAutomation_DescriptorImpl_warnings_missingBuildFile());
  return FormValidation.validateRequired(value);
  }
 
  public FormValidation doCheckTestPlan(@QueryParameter String value)
  throws IOException, ServletException {
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return FormValidation.ok();
+ }
  if (value.length() == 0)
  return FormValidation.warning(Messages.ProvarAutomation_DescriptorImpl_warnings_missingTestPlan());
 
@@ -391,6 +397,9 @@ public FormValidation doCheckTestPlan(@QueryParameter String value)
 
  public FormValidation doCheckTestFolder(@QueryParameter String value)
  throws IOException, ServletException {
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return FormValidation.ok();
+ }
  if (value.length() == 0)
  return FormValidation.warning(Messages.ProvarAutomation_DescriptorImpl_warnings_missingTestFolder());
 
@@ -399,6 +408,9 @@ public FormValidation doCheckTestFolder(@QueryParameter String value)
 
  public FormValidation doCheckSecretsPassword(@QueryParameter String value)
  throws IOException, ServletException {
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return FormValidation.ok();
+ }
  if (value.length() == 0)
  return FormValidation.warning(Messages.ProvarAutomation_DescriptorImpl_warnings_noSecretsPassword());
 
@@ -407,7 +419,9 @@ public FormValidation doCheckSecretsPassword(@QueryParameter String value)
 
  public FormValidation doCheckProjectName(@QueryParameter String value)
  throws IOException, ServletException {
-
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return FormValidation.ok();
+ }
  if (value.length() == 0)
  return FormValidation.ok(Messages.ProvarAutomation_DescriptorImpl_warnings_projectFolderMissing());
 
@@ -443,6 +457,9 @@ public boolean configure(StaplerRequest req, JSONObject json) throws FormExcepti
 
  public ListBoxModel doFillBrowserItems() {
  ListBoxModel items = new ListBoxModel();
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return items;
+ }
  items.add("Chrome (Headless)", Browser.Chrome_Headless.name());
  items.add("Chrome", Browser.Chrome.name());
  items.add("Edge", Browser.Edge.name());
@@ -456,14 +473,20 @@ public ListBoxModel doFillBrowserItems() {
 
  public ListBoxModel doFillSalesforceMetadataCacheSettingItems() {
  ListBoxModel items = new ListBoxModel();
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return items;
+ }
  items.add("Reuse", SalesforceMetadataCacheSettings.Reuse.name());
  items.add("Refresh", SalesforceMetadataCacheSettings.Refresh.name());
  items.add("Reload", SalesforceMetadataCacheSettings.Reload.name());
  return items;
  }
 
- public ListBoxModel doFillResultsPathSettingItems(){
+ public ListBoxModel doFillResultsPathSettingItems() {
  ListBoxModel items = new ListBoxModel();
+ if (!Jenkins.get().hasPermission(Jenkins.ADMINISTER)) {
+ return items;
+ }
  items.add("Increment", ResultsPathSettings.Increment.name());
  items.add("Replace", ResultsPathSettings.Replace.name());
  items.add("Fail", ResultsPathSettings.Fail.name());