Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CLI argument hint for PHPStan #1856

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

Murl080
Copy link
Contributor

@Murl080 Murl080 commented Oct 8, 2024

Without the equals sign, I got the following error using PHPStan v1.12.4:

The "--error-format checkstyle" option does not exist.  

analyse [-c|--configuration CONFIGURATION] [-l|--level LEVEL] [--no-progress] [--debug] [-a|--autoload-file AUTOLOAD-FILE] [--error-format ERROR-FORMAT] [-b|--generate-baseline [GENERATE-BASELINE]] [--allow-empty-baseline] [--memory-limit MEMORY-LIMIT] [--xdebug] [--fix] [--watch] [--pro] [--fail-without-result-cache] [--] [<paths>...]

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Without the equals sign, I got the following error using PHPStan v1.12.4:

```
The "--error-format checkstyle" option does not exist.  

analyse [-c|--configuration CONFIGURATION] [-l|--level LEVEL] [--no-progress] [--debug] [-a|--autoload-file AUTOLOAD-FILE] [--error-format ERROR-FORMAT] [-b|--generate-baseline [GENERATE-BASELINE]] [--allow-empty-baseline] [--memory-limit MEMORY-LIMIT] [--xdebug] [--fix] [--watch] [--pro] [--fail-without-result-cache] [--] [<paths>...]
```
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (5a1eb90) to head (7136eeb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1856      +/-   ##
============================================
- Coverage     82.66%   82.57%   -0.10%     
+ Complexity     1362     1360       -2     
============================================
  Files           249      249              
  Lines          5233     5233              
  Branches        402      402              
============================================
- Hits           4326     4321       -5     
- Misses          798      802       +4     
- Partials        109      110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the documentation Enhancement of documentation label Oct 8, 2024
@uhafner
Copy link
Member

uhafner commented Oct 8, 2024

Thanks for spotting!

@uhafner uhafner merged commit 3bee389 into jenkinsci:main Oct 8, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhancement of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants