Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docuemnts evaluator, refactor validators #151

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Add docuemnts evaluator, refactor validators #151

merged 10 commits into from
Nov 14, 2023

Conversation

jerpint
Copy link
Owner

@jerpint jerpint commented Nov 13, 2023

No description provided.

buster/llm_utils/embeddings.py Show resolved Hide resolved
buster/validators/question_answer_validator.py Outdated Show resolved Hide resolved
buster/examples/cfg.py Outdated Show resolved Hide resolved

logger = logging.getLogger(__name__)
logging.basicConfig(level=logging.INFO)


class Validator(ABC):
class Validator:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really a reason for this class now?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder the same thing, but it helps keep the code more organized

buster/validators/question_answer_validator.py Outdated Show resolved Hide resolved
buster/validators/question_answer_validator.py Outdated Show resolved Hide resolved
@jerpint jerpint changed the title Add docuemnts evaluator, refactor validators to begin with Add docuemnts evaluator, refactor validators Nov 14, 2023
if check_question_prompt is None:
check_question_prompt = (
"""You are a chatbot answering questions on documentation.
Your job is to determine wether or not a question is valid, and should be answered.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo wether -> whether

@jerpint jerpint merged commit 64ba998 into main Nov 14, 2023
1 check passed
@jerpint jerpint deleted the validate-sources branch November 14, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants