Use latest C# features

Yosu.Core/Utils/DelegateEqualityComparer.cs

@@ -3,16 +3,10 @@
 
 namespace Yosu.Core.Utils;
 
-public class DelegateEqualityComparer<T> : IEqualityComparer<T>
+public class DelegateEqualityComparer<T>(Func<T, T, bool> equals, Func<T, int> getHashCode) : IEqualityComparer<T>
 {
-    private readonly Func<T, T, bool> _equals;
-    private readonly Func<T, int> _getHashCode;
-
-    public DelegateEqualityComparer(Func<T, T, bool> equals, Func<T, int> getHashCode)
-    {
-        _equals = equals;
-        _getHashCode = getHashCode;
-    }
+    private readonly Func<T, T, bool> _equals = equals;
+    private readonly Func<T, int> _getHashCode = getHashCode;
 
     public bool Equals(T? x, T? y)
     {

Yosu.Core/Utils/ThrottleLock.cs

@@ -4,14 +4,12 @@
 
 namespace Yosu.Core.Utils;
 
-public class ThrottleLock : IDisposable
+public class ThrottleLock(TimeSpan interval) : IDisposable
 {
     private readonly SemaphoreSlim _semaphore = new(1, 1);
-    private readonly TimeSpan _interval;
+    private readonly TimeSpan _interval = interval;
     private DateTimeOffset _lastRequestInstant = DateTimeOffset.MinValue;
 
-    public ThrottleLock(TimeSpan interval) => _interval = interval;
-
     public async Task WaitAsync(CancellationToken cancellationToken = default)
     {
         await _semaphore.WaitAsync(cancellationToken);

Yosu.Soundcloud.Core/Tagging/MediaFile.cs

@@ -4,11 +4,9 @@
 
 namespace Yosu.Soundcloud.Core.Tagging;
 
-internal partial class MediaFile : IDisposable
+internal partial class MediaFile(TagFile file) : IDisposable
 {
-    private readonly TagFile _file;
-
-    public MediaFile(TagFile file) => _file = file;
+    private readonly TagFile _file = file;
 
     public void SetThumbnail(byte[] thumbnailData) =>
         _file.Tag.Pictures = [new Picture(thumbnailData)];

Yosu.Spotify.Core/Tagging/MediaFile.cs

@@ -12,11 +12,9 @@
 
 namespace Yosu.Spotify.Core.Tagging;
 
-internal partial class MediaFile : IDisposable
+internal partial class MediaFile(TagFile file) : IDisposable
 {
-    private readonly TagFile _file;
-
-    public MediaFile(TagFile file) => _file = file;
+    private readonly TagFile _file = file;
 
     /*public void SetThumbnail(byte[] thumbnailData)
     {

Yosu.Youtube.Converter/ConversionFormat.cs

@@ -7,24 +7,22 @@ namespace Yosu.Youtube.Converter;
 /// <summary>
 /// Encapsulates conversion media format.
 /// </summary>
+/// <remarks>
+/// Initializes an instance of <see cref="ConversionFormat" />.
+/// </remarks>
 [Obsolete("Use YoutubeExplode.Videos.Streams.Container instead"), ExcludeFromCodeCoverage]
-public readonly struct ConversionFormat
+public readonly struct ConversionFormat(string name)
 {
     /// <summary>
     /// Format name.
     /// </summary>
-    public string Name { get; }
+    public string Name { get; } = name;
 
     /// <summary>
     /// Whether this format is a known audio-only format.
     /// </summary>
     public bool IsAudioOnly => new Container(Name).IsAudioOnly();
 
-    /// <summary>
-    /// Initializes an instance of <see cref="ConversionFormat" />.
-    /// </summary>
-    public ConversionFormat(string name) => Name = name;
-
     /// <inheritdoc />
     public override string ToString() => Name;
 }

Yosu.Youtube.Converter/ConversionRequest.cs

@@ -7,22 +7,30 @@ namespace Yosu.Youtube.Converter;
 /// <summary>
 /// Conversion options.
 /// </summary>
-public class ConversionRequest
+/// <remarks>
+/// Initializes an instance of <see cref="ConversionRequest" />.
+/// </remarks>
+public class ConversionRequest(
+    string ffmpegCliFilePath,
+    string outputFilePath,
+    Container container,
+    ConversionPreset preset
+    )
 {
     /// <summary>
     /// Path to FFmpeg CLI.
     /// </summary>
-    public string FFmpegCliFilePath { get; }
+    public string FFmpegCliFilePath { get; } = ffmpegCliFilePath;
 
     /// <summary>
     /// Output file path.
     /// </summary>
-    public string OutputFilePath { get; }
+    public string OutputFilePath { get; } = outputFilePath;
 
     /// <summary>
     /// Output container.
     /// </summary>
-    public Container Container { get; }
+    public Container Container { get; } = container;
 
     /// <summary>
     /// Output format.
@@ -33,23 +41,7 @@ public class ConversionRequest
     /// <summary>
     /// Encoder preset.
     /// </summary>
-    public ConversionPreset Preset { get; }
-
-    /// <summary>
-    /// Initializes an instance of <see cref="ConversionRequest" />.
-    /// </summary>
-    public ConversionRequest(
-        string ffmpegCliFilePath,
-        string outputFilePath,
-        Container container,
-        ConversionPreset preset
-    )
-    {
-        FFmpegCliFilePath = ffmpegCliFilePath;
-        OutputFilePath = outputFilePath;
-        Container = container;
-        Preset = preset;
-    }
+    public ConversionPreset Preset { get; } = preset;
 
     /// <summary>
     /// Initializes an instance of <see cref="ConversionRequest" />.

Yosu.Youtube.Converter/ConversionRequestBuilder.cs

@@ -10,19 +10,17 @@ namespace Yosu.Youtube.Converter;
 /// <summary>
 /// Builder for <see cref="ConversionRequest" />.
 /// </summary>
-public partial class ConversionRequestBuilder
+/// <remarks>
+/// Initializes an instance of <see cref="ConversionRequestBuilder" />.
+/// </remarks>
+public partial class ConversionRequestBuilder(string outputFilePath)
 {
-    private readonly string _outputFilePath;
+    private readonly string _outputFilePath = outputFilePath;
 
     private string? _ffmpegCliFilePath;
     private Container? _container;
     private ConversionPreset _preset;
 
-    /// <summary>
-    /// Initializes an instance of <see cref="ConversionRequestBuilder" />.
-    /// </summary>
-    public ConversionRequestBuilder(string outputFilePath) => _outputFilePath = outputFilePath;
-
     private Container GetDefaultContainer() =>
         new(Path.GetExtension(_outputFilePath).TrimStart('.').NullIfWhiteSpace() ?? "mp4");
 

Yosu.Youtube.Converter/Converter.cs

@@ -13,18 +13,11 @@
 
 namespace Yosu.Youtube.Converter;
 
-internal partial class Converter
+internal partial class Converter(VideoClient videoClient, FFmpeg ffmpeg, ConversionPreset preset)
 {
-    private readonly VideoClient _videoClient;
-    private readonly FFmpeg _ffmpeg;
-    private readonly ConversionPreset _preset;
-
-    public Converter(VideoClient videoClient, FFmpeg ffmpeg, ConversionPreset preset)
-    {
-        _videoClient = videoClient;
-        _ffmpeg = ffmpeg;
-        _preset = preset;
-    }
+    private readonly VideoClient _videoClient = videoClient;
+    private readonly FFmpeg _ffmpeg = ffmpeg;
+    private readonly ConversionPreset _preset = preset;
 
     private async ValueTask ProcessAsync(
         string filePath,
@@ -233,17 +226,11 @@ await ProcessAsync(
 
 internal partial class Converter
 {
-    private class StreamInput : IDisposable
+    private class StreamInput(IStreamInfo info, string filePath) : IDisposable
     {
-        public IStreamInfo Info { get; }
-
-        public string FilePath { get; }
+        public IStreamInfo Info { get; } = info;
 
-        public StreamInput(IStreamInfo info, string filePath)
-        {
-            Info = info;
-            FilePath = filePath;
-        }
+        public string FilePath { get; } = filePath;
 
         public void Dispose()
         {
@@ -258,17 +245,11 @@ public void Dispose()
         }
     }
 
-    private class SubtitleInput : IDisposable
+    private class SubtitleInput(ClosedCaptionTrackInfo info, string filePath) : IDisposable
     {
-        public ClosedCaptionTrackInfo Info { get; }
-
-        public string FilePath { get; }
+        public ClosedCaptionTrackInfo Info { get; } = info;
 
-        public SubtitleInput(ClosedCaptionTrackInfo info, string filePath)
-        {
-            Info = info;
-            FilePath = filePath;
-        }
+        public string FilePath { get; } = filePath;
 
         public void Dispose()
         {

Yosu.Youtube.Converter/FFmpeg/FFmpeg.android.cs

@@ -5,11 +5,9 @@
 
 namespace Yosu.Youtube.Converter;
 
-internal class FFmpeg
+internal class FFmpeg(string filePath)
 {
-    private readonly string _filePath;
-
-    public FFmpeg(string filePath) => _filePath = filePath;
+    private readonly string _filePath = filePath;
 
     public void Execute(
         string arguments,

Yosu.Youtube.Converter/FFmpeg/FFmpeg.macios.cs

@@ -5,11 +5,9 @@
 
 namespace Yosu.Youtube.Converter;
 
-internal class FFmpeg
+internal class FFmpeg(string filePath)
 {
-    private readonly string _filePath;
-
-    public FFmpeg(string filePath) => _filePath = filePath;
+    private readonly string _filePath = filePath;
 
     public void Execute(
         string arguments,

Yosu.Youtube.Converter/FFmpeg/FFmpeg.net.cs

@@ -14,11 +14,9 @@ namespace Yosu.Youtube.Converter;
 // Ideally this should use named pipes and stream through stdout.
 // However, named pipes aren't well supported on non-Windows OS and
 // stdout streaming only works with some specific formats.
-internal partial class FFmpeg
+internal partial class FFmpeg(string filePath)
 {
-    private readonly string _filePath;
-
-    public FFmpeg(string filePath) => _filePath = filePath;
+    private readonly string _filePath = filePath;
 
     public async ValueTask ExecuteAsync(
         string arguments,
@@ -58,16 +56,14 @@ public async ValueTask ExecuteAsync(
 
 internal partial class FFmpeg
 {
-    private class FFmpegProgressRouter : PipeTarget
+    private class FFmpegProgressRouter(IProgress<double> output) : PipeTarget
     {
         private readonly StringBuilder _buffer = new();
-        private readonly IProgress<double> _output;
+        private readonly IProgress<double> _output = output;
 
         private TimeSpan? _totalDuration;
         private TimeSpan? _lastOffset;
 
-        public FFmpegProgressRouter(IProgress<double> output) => _output = output;
-
         private TimeSpan? TryParseTotalDuration(string data) =>
             data.Pipe(s => Regex.Match(s, @"Duration:\s(\d\d:\d\d:\d\d.\d\d)").Groups[1].Value)
                 .NullIfWhiteSpace()

Yosu.Youtube.Converter/FFmpeg/FFmpeg.windows.cs

@@ -5,11 +5,9 @@
 
 namespace Yosu.Youtube.Converter;
 
-internal class FFmpeg
+internal class FFmpeg(string filePath)
 {
-    private readonly string _filePath;
-
-    public FFmpeg(string filePath) => _filePath = filePath;
+    private readonly string _filePath = filePath;
 
     public async ValueTask ExecuteAsync(
         string arguments,

Yosu.Youtube.Converter/Utils/ProgressMuxer.cs

@@ -3,16 +3,14 @@
 
 namespace Yosu.Youtube.Converter.Utils;
 
-internal class ProgressMuxer
+internal class ProgressMuxer(IProgress<double> target)
 {
-    private readonly IProgress<double> _target;
+    private readonly IProgress<double> _target = target;
 
     private readonly object _lock = new();
     private readonly Dictionary<int, double> _splitWeights = [];
     private readonly Dictionary<int, double> _splitValues = [];
 
-    public ProgressMuxer(IProgress<double> target) => _target = target;
-
     public IProgress<double> CreateInput(double weight = 1)
     {
         lock (_lock)

Yosu.Youtube.Core/Tagging/MediaFile.cs

@@ -12,11 +12,9 @@
 
 namespace Yosu.Youtube.Core.Tagging;
 
-internal partial class MediaFile : IDisposable
+internal partial class MediaFile(TagFile file) : IDisposable
 {
-    private readonly TagFile _file;
-
-    public MediaFile(TagFile file) => _file = file;
+    private readonly TagFile _file = file;
 
     /*public void SetThumbnail(byte[] thumbnailData)
     {

Yosu/Platforms/Android/MainApplication.cs

@@ -7,10 +7,7 @@
 namespace Yosu;
 
 [Application(UsesCleartextTraffic = true)]
-public class MainApplication : MauiApplication
+public class MainApplication(IntPtr handle, JniHandleOwnership ownership) : MauiApplication(handle, ownership)
 {
-    public MainApplication(IntPtr handle, JniHandleOwnership ownership)
-        : base(handle, ownership) { }
-
     protected override MauiApp CreateMauiApp() => MauiProgram.CreateMauiApp();
 }

Yosu/Utils/ResizableSemaphore.cs

@@ -88,11 +88,9 @@ public void Dispose()
 
 internal partial class ResizableSemaphore
 {
-    private class AcquiredAccess : IDisposable
+    private class AcquiredAccess(ResizableSemaphore semaphore) : IDisposable
     {
-        private readonly ResizableSemaphore _semaphore;
-
-        public AcquiredAccess(ResizableSemaphore semaphore) => _semaphore = semaphore;
+        private readonly ResizableSemaphore _semaphore = semaphore;
 
         public void Dispose() => _semaphore.Release();
     }

Yosu/ViewModels/Framework/ListGroup.cs

@@ -2,13 +2,7 @@
 
 namespace Yosu.ViewModels.Framework;
 
-public class ListGroup<T> : List<T>
+public class ListGroup<T>(string name, List<T> items) : List<T>(items)
 {
-    public string Name { get; }
-
-    public ListGroup(string name, List<T> items)
-        : base(items)
-    {
-        Name = name;
-    }
+    public string Name { get; } = name;
 }