Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of unicode escape codes #3747

Closed
GR3YH4TT3R93 opened this issue Jul 14, 2024 · 6 comments · Fixed by #3975
Closed

Incorrect parsing of unicode escape codes #3747

GR3YH4TT3R93 opened this issue Jul 14, 2024 · 6 comments · Fixed by #3975
Labels
bug Something isn't working

Comments

@GR3YH4TT3R93
Copy link

Describe the bug
In the latest release (v0.43.1), some icons (e.g. nuxt.config.ts which uses the escape sequence \uf1106, and tailwind.config.ts which uses the escape sequence \uf13ff) are showing the incorrect icons (e.g. for nuxt.config.ts \uf110+6 shown as icon6 instead of \f1106 and for tailwind.config.ts \uf13f+f shown as iconf instead of \uf13ff).

To Reproduce
Steps to reproduce the behavior:

  1. git init
  2. touch nuxt.config.ts tailwind.config.ts
  3. lazygit
  4. See error

Expected behavior
Expected to see the proper icons

Version info:
commit=v0.43.1, build date=2024-07-13T12:12:22Z, build source=termux, version=0.43.1, os=android, arch=arm64, git version=2.45.2
git version 2.45.2

@GR3YH4TT3R93 GR3YH4TT3R93 added the bug Something isn't working label Jul 14, 2024
@GR3YH4TT3R93 GR3YH4TT3R93 changed the title [BUG] incorrect parsing of unicode escape codes Incorrect parsing of unicode escape codes Jul 14, 2024
@GR3YH4TT3R93
Copy link
Author

Sorry, you'll also need to ensure to set nerdFontsVersion: "3" in your ~/.config/lazygit/config.yml for the repro

@bmichotte
Copy link

bmichotte commented Aug 23, 2024

I have the same issue

CleanShot 2024-08-23 at 13 03 21@2x

And I also can confirm that it's not an issue from my font, here's the screenshot from pkg/gui/presentation/icons/file_icons.go

CleanShot 2024-08-23 at 13 03 59@2x

as well as in neo-tree
CleanShot 2024-08-23 at 13 05 26@2x

@xzhang8102
Copy link

I encountered a similar problem.
LazyVim/LazyVim#4559 (comment)

@stefanhaller stefanhaller mentioned this issue Oct 9, 2024
7 tasks
@stefanhaller
Copy link
Collaborator

Here's a fix: #3975

@GR3YH4TT3R93
Copy link
Author

It works! Thank You!
Screenshot_2024-10-09-20-04-46-49_84d3000e3f4017145260f7618db1d683

@bmichotte
Copy link

Can confirm it's working for me as well. Thanks @stefanhaller

CleanShot 2024-10-10 at 08 33 44@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants