Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file icons #3975

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix file icons #3975

merged 2 commits into from
Oct 13, 2024

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

Some file icons weren't drawn correctly, e.g. the ones for tailwind.config.ts or nuxt.config.ts, but also many others.

Fixes #3747.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Copy link

codacy-production bot commented Oct 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4e361e11
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4e361e1) Report Missing Report Missing Report Missing
Head commit (f71274b) 50620 43525 85.98%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3975) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@stefanhaller stefanhaller added the bug Something isn't working label Oct 9, 2024
The string literal "\uf0868" does *not* create a single rune with the code point
f0868, as was intended; instead, it creates two runes, one with the code point
f086, followed by the character '8'.
This should prevent errors like that from happening again.
@stefanhaller stefanhaller merged commit 53f8249 into master Oct 13, 2024
16 checks passed
@stefanhaller stefanhaller deleted the fix-file-icons branch October 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of unicode escape codes
3 participants