Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DiffContextSize to be decreased to zero #4050

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LuxxxLucy
Copy link

@LuxxxLucy LuxxxLucy commented Nov 8, 2024

  • PR Description

Per #4012, the diff context size should be able to be decreased to zero. I update the type def for DiffContextSize to be an unsigned integer and add saturated add and subtraction in context_lines_controller.go where the variable is updated (++ or --)

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield jesseduffield added the enhancement New feature or request label Nov 9, 2024
Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@LuxxxLucy
Copy link
Author

updated with newest commit that should fix the CI complaint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants