Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply Centralized Package Management #330

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: Apply Centralized Package Management #330

wants to merge 1 commit into from

Conversation

bartelink
Copy link
Collaborator

Works on CI, but not in Rider latest or 2022.2 EAP 1

@bartelink
Copy link
Collaborator Author

Shaved this off master as Rider is not happy...

  • I have .NET SDK 6.0.300 installed, and a local build via dotnet build ./build.proj is happy

  • However when I try to build in IDE, its using the V5 compiler (errors about nameof etc, and the FSharp.Core reflects that too (errors re string interpolation not being supported by underlying lib etc))

Flipping 'Use Resharper Build' doesn't make any difference, and my limited imagination has hit the wall..

(ASIDE: I'm sure this is logged somewhere in some YouTrack, but the lack of autocomplete on Version="" attributes in PackageVersion elements makes it suboptimal compared to leaving it as-is too)

cc @auduchinok

@auduchinok
Copy link

auduchinok commented Jun 1, 2022

@bartelink Thanks for mentioning me. Could you check what MSBuild version do you have in settings for this solution?

Screenshot 2022-06-01 at 16 16 57

@bartelink
Copy link
Collaborator Author

bartelink commented Jun 1, 2022

Apologies for atting you in - I'm just not sure about what it could possibly be so didnt want to log an unreproable issue at this point (and I realise it's probably not F# specific, which makes it a doubly cheeky thing to do, sorry).

Am on a Mac, it shows:
image

The repo should clone pretty cleanly and a dotnet build ./build.proj vs IDE build comparison should be a reasonably quick thing to do (or are you saying you've done that and it works in your context?)

@bartelink
Copy link
Collaborator Author

bartelink commented Jun 1, 2022

It should be noted that Centralized Package Management is at pains to point out that it is in preview and subject to change (thought its been around for a bit) so I'm not necessarily demanding a fix, just making sure someone in JetBrains knows of the issue such that the best possible resolution can be arrived at in the global sense, i.e. its very possible this is something that results from an over-aggressive assumption on the NuGet or SDK side.

ASIDE: I'm also reconsidering whether to ever consider leaning on CPVM as I definitely want to be able to retain the ability to 'inline' a package from Equinox into a consuming solution by

  1. adding the Equinox project into the app solution
  2. commenting out the Package Reference in the app
  3. adding a ProjectReference to replace it (e.g. by checking the relevant box in the Add reference context menu in the references of my app project)

... unless the Msbuild logic is such that a <PackageReference Include="FsCodec" /> with a missing Version can correctly pick it up by walking up to the correct relevant Directory.Packages.props from its repo as opposed to relying on the app including all the things it would get from there, there will be an issue (have not tested with just MsBuild, but ran into this same issue in Rider on a Windows box with a colleague just now).

@auduchinok
Copy link

auduchinok commented Jul 26, 2022

@bartelink It looks like it may get fixed in RIDER-41805.

@bartelink bartelink force-pushed the master branch 2 times, most recently from fe2af41 to edda98d Compare June 5, 2023 16:06
@bartelink bartelink changed the title Apply Centralized Package Management chore: Apply Centralized Package Management Jul 26, 2023
@bartelink bartelink force-pushed the master branch 5 times, most recently from 7053335 to 07a8d79 Compare December 15, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants