Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected the hover issue #1243

Merged
merged 4 commits into from
Jun 18, 2024
Merged

corrected the hover issue #1243

merged 4 commits into from
Jun 18, 2024

Conversation

Shreyaa173
Copy link
Contributor

@Shreyaa173 Shreyaa173 commented Jun 16, 2024

Pull Request

Description

The GitHub and discord icon is not visible earlier on hovering in dark theme
Closes #1180

Type of change

  • Adding a new Resource
  • Website enhancement or fixes

Checklist:

  • I read carefully CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Screenshots (if appropriate):

before
Screenshot 2024-06-15 104612

after
image

Additional

Can you please assign it under level 2 as I changed a lot of code to do this work

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@jfmartinz
Copy link
Owner

Can I see the ouput? Like maybe mp4, we dont have a preview yet.

@jfmartinz jfmartinz removed the level1 label Jun 17, 2024
@Shreyaa173
Copy link
Contributor Author

Shreyaa173 commented Jun 17, 2024

here it is

ResourceHub.and.1.more.page.-.Personal.-.Microsoft.Edge.2024-06-17.12-57-12.mp4

@jfmartinz jfmartinz merged commit 2d166bb into jfmartinz:main Jun 18, 2024
0 of 2 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] - github and discord icon is not visible
2 participants