Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSA implemations of several Programming languages #930

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

Pujan-sarkar
Copy link
Contributor

Pull Request

Description

This repository contains a collection of Data Structures and Algorithms (DSA) implementations across various programming languages. Each section is organized by language and includes common DSA topics such as arrays, strings, linked lists, trees, and more.

Fixes #796

Type of change

  • Adding a new Resource
  • Adding a new Category
  • Documentation enhancement or fixes
  • Website enhancement or fixes

Checklist:

  • I read carefully CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link

github-actions bot commented Jun 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz please check this pr and merge .

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz please merge the pr please

@jfmartinz
Copy link
Owner

You don't need to add new readme, just add it here

Follow this format, each language should have their own table
image

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz I add a new folder please level 3 or level 2 .

@jfmartinz
Copy link
Owner

Follow this format for adding a new table:

https://github.com/jfmartinz/ResourceHub/blob/main/CONTRIBUTING.md

@jfmartinz jfmartinz added level2 and removed level1 labels Jun 8, 2024
@jfmartinz
Copy link
Owner

Add it into a table. Each programing language shoukld have a table each

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz please check I have done the changes as you said earlier.

Copy link
Owner

@jfmartinz jfmartinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow this format for table:

C++

Resource Name Description
String RESOURCE DESCRIPTION

JavaSCript

Resource Name Description
String RESOURCE DESCRIPTION

Data Structures and Algorithm (DSA)/readme.md Outdated Show resolved Hide resolved
Pujan-sarkar and others added 3 commits June 9, 2024 09:41
Co-authored-by: Joseph Martin <129386460+jfmartinz@users.noreply.github.com>
@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz sir check now , I think this is good , so please merge it.

@jfmartinz
Copy link
Owner

Follow the format. Each table should have only 2 cols, Resource Name and Description.

Data Structures and Algorithm (DSA)/readme.md Outdated Show resolved Hide resolved
Data Structures and Algorithm (DSA)/readme.md Outdated Show resolved Hide resolved
Data Structures and Algorithm (DSA)/readme.md Outdated Show resolved Hide resolved
Pujan-sarkar and others added 3 commits June 9, 2024 21:02
Co-authored-by: Joseph Martin <129386460+jfmartinz@users.noreply.github.com>
@Pujan-sarkar
Copy link
Contributor Author

Pujan-sarkar commented Jun 9, 2024

@jfmartinz I guess now all the changes has done ✌️

Copy link
Owner

@jfmartinz jfmartinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it:
image

add space before the '-'. Like this

  • C++
  • JS
  1. Change the heading to DSA by language

  2. Remove the roadmap col in C++, Java, Python, JS
    image

  3. I already provided the template for addign new table and still not following it.

Check the format of your table, is your table same thing with this format:

### Section name
<table width="100%">
 <tr>
   <th>Resource Name</th>
   <th>Description</th>
 </tr>
 <tr>
   <td><a href="URL HERE">RESOURCE NAME</a></td>
   <td>RESOURCE DESCRIPTION</td>
 </tr>
</table>
  1. Remove these lines between the tables:
    image

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz now check

@Pujan-sarkar
Copy link
Contributor Author

@jfmartinz If this is not working then unassign me i will work on any other issue

Copy link
Owner

@jfmartinz jfmartinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTML!

@jfmartinz jfmartinz merged commit f45e2a5 into jfmartinz:main Jun 13, 2024
0 of 2 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Data Structures and Algorithms (DSA) Implementations for Each Programming Language
2 participants