Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added algorithms by languages section #958

Closed

Conversation

ImmidiSivani
Copy link
Contributor

Description

added algorithms for 3 languages in DSA .

Closes #759

Type of change

  • Adding a new Resource
  • Adding a new Category
  • Documentation enhancement or fixes
  • Website enhancement or fixes

Checklist:

  • I read carefully CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Screenshots (if appropriate):

Please add screenshots to help explain your changes.

Additional

Copy link

github-actions bot commented Jun 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@@ -218,6 +219,55 @@ To the Point, Short and Practical - These 3 terms defines our Content
</tr>
</table>

### Algorithms by Languages

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add a description here

Comment on lines 224 to 269
<table width="100%" id="algorithms-by-languages">
<tr>
<th>JavaScript</th>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=P6XGSKO2RzI&t=519s">Quick Sort</a></td>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=x_Z9FcAPmbk&t=1s">Merge Sort</a></td>
</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=75jGy1xAhhs&t=2s">Binary Search</a></td>
</tr>
<tr>
<th>Java</th>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=h8eyY7dIiN4&t=2s">Quick Sort</a></td>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=bOk35XmHPKs&t=1s">Merge Sort</a></td>
</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=NFhOrxtXXcM&t=1s">Binary Search</a></td>
</tr>
<tr>
<th>Python</th>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=kFeXwkgnQ9U&t=1s">Quick Sort</a></td>

</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=cVZMah9kEjI&t=1s">Merge Sort</a></td>
</tr>
<tr>
<td><a href="https://www.youtube.com/watch?v=cVZMah9kEjI&t=1s">Binary Search</a></td>
</tr>


</table>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add a description in each resource. Check this link

Copy link
Owner

@jfmartinz jfmartinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each language should have its own table like this:

JavaScript

Section name

Resource Name Description
RESOURCE NAME RESOURCE DESCRIPTION

Java

Section name

Resource Name Description
RESOURCE NAME RESOURCE DESCRIPTION

I hope this is clear

@jfmartinz
Copy link
Owner

You just need to add '>' before the description, why did you close? After that change I can merged it

@ImmidiSivani ImmidiSivani reopened this Jun 15, 2024
@ImmidiSivani
Copy link
Contributor Author

ImmidiSivani commented Jun 15, 2024

This branch has conflicts shall I create new branch and open new PR for review ?,if it is okay I will close this PR.

@jfmartinz
Copy link
Owner

You can fix it if you want here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [FEATURE] - Add DSA Projects
2 participants