Fix accessing credentials when authorize project is enabled #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
kneirinck
force-pushed
the
feature/access_credentials_when_authorize_project_is_enabled
branch
from
62f18a3
to
5a9aedc
Compare
|
@yahavi could you re-add the safe to test label? Seems it got removed because of my (force) push |
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
…orize_project_is_enabled
…orize_project_is_enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the authorize-project plugin and restricting a job to run as a specific user,
rtUploadfails to retrieve the stored credentials.This happens for both a globally defined server as well as a locally defined server with
rtServer.After quite a bit of digging I found out that it's related to not using the
Runcontext to access/find credentials.This PR changes the credential retrieval in as many places as possible to use a
Runcontext if available and applicable.It's inspired by jenkinsci/docker-commons-plugin#68 (review)
This fixes #247
passed.