-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #523 Add capability to specify proxy for repository replications #524
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline suggestion.
As for the test, I think that we can avoid adding it in this case.
The force push was because I had accidentally committed the fix using a different user and needed to re-write that commit. @eyalbe4 I noticed that there was an xray test that was failing from your test trigger. Do you have any insights into what might be causing that? Thanks in advance! |
import "encoding/json" | ||
|
||
type ReplicationBody struct { | ||
type replicationBody struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside of this change to have two new structs of GetReplicationBody
and UpdateReplicationBody
rather than overriding the JSONUnmarshal function is that this change is no longer backwards compatible.
Even if I keep choose to keep replicationBody
exposed, the function specs in artifactory/services/createreplication.go and artifactory/services/getreplication.go will be changed which are backward incompatible changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Guent4 -
We're mostly okay with breaking compatibility following APO changes. If a public API changed, we make sure to note it in the release notes.
Thanks so much for this important addition @Guent4. |
I have a use case where I am trying to configure Artifactory replications through Terraform and need to be able to set a proxy for the replication. Couple things to note about the current changes: