Fixing various issues reported by static code analysis and compiler w…

…arnings

CMakeLists.txt

@@ -22,6 +22,7 @@ if (MSVC)
  # Thank you Microsoft. Its so nice of you to give us all these meaningful reasons to stay up all night.
  check_cxx_compiler_flag("/std:c++20" COMPILER_SUPPORTS_CXX20)
  check_cxx_compiler_flag("/std:c++17" COMPILER_SUPPORTS_CXX17)
+ add_compile_options(/Zc:__cplusplus)
 else()
  check_cxx_compiler_flag("-std=c++20" COMPILER_SUPPORTS_CXX20)
  check_cxx_compiler_flag("-std=c++17" COMPILER_SUPPORTS_CXX17)

include/restc-cpp/IteratorFromJsonSerializer.h

@@ -43,7 +43,7 @@ class IteratorFromJsonSerializer
  }
 
  Iterator(Iterator&& it)
- : owner_{it.owner_}, data_{move(it.data_)} {}
+  : owner_{it.owner_}, data_{std::move(it.data_)} {}
 
  Iterator(IteratorFromJsonSerializer *owner)
  : owner_{owner} {}
@@ -71,7 +71,7 @@ class IteratorFromJsonSerializer
 
  Iterator& operator = (Iterator&& it) {
  owner_ = it.owner_;
- it.data_ = move(it.data_);
+ it.data_ = std::move(it.data_);
  }
 
  bool operator == (const Iterator& other) const {
@@ -171,7 +171,7 @@ class IteratorFromJsonSerializer
  RapidJsonDeserializer<objectT> handler(
  *data, *properties_);
  json_reader_.Parse(reply_stream_, handler);
- return move(data);
+ return std::move(data);
  } else if (ch == ']') {
  reply_stream_.Take();
  state_ = State::DONE;

include/restc-cpp/RequestBuilder.h

@@ -187,7 +187,7 @@ class RequestBuilder
  args_ = Request::args_t();
  }
 
- args_->push_back({move(name), move(value)});
+ args_->push_back({std::move(name), std::move(value)});
  return *this;
  }
 
@@ -202,14 +202,14 @@ class RequestBuilder
  * \param value Value of the argument
  */
  RequestBuilder& Argument(std::string name, int64_t value) {
- return Argument(move(name), std::to_string(value));
+ return Argument(std::move(name), std::to_string(value));
  } 
 
  /*! Supply your own RequestBody to the request
  */
  RequestBuilder& Body(std::unique_ptr<RequestBody> body) {
  assert(!body_);
- body_ = move(body);
+ body_ = std::move(body);
  return *this;
  }
 
@@ -252,7 +252,7 @@ class RequestBuilder
  */
  RequestBuilder& Data(std::string&& body) {
  assert(!body_);
- body_ = RequestBody::CreateStringBody(move(body));
+ body_ = RequestBody::CreateStringBody(std::move(body));
  return *this;
  }
 
@@ -368,7 +368,7 @@ class RequestBuilder
  }
 #endif
  auto req = Request::Create(
- url_, type_, ctx_->GetClient(), move(body_), args_, headers_, auth_);
+ url_, type_, ctx_->GetClient(), std::move(body_), args_, headers_, auth_);
 
  auto orig = req->GetProperties();
 

include/restc-cpp/restc-cpp.h

@@ -423,7 +423,7 @@ class RestClient {
  done_handler.reset();
  });
 
- return move(future);
+ return future;
  }
 
  /*! Process from within an existing coroutine */