Allow authentication with empty password and also no authentication at all #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not seem to allow authentication with empty username (only password). Line 71 " if self.__url.username is not None: " should check that both username and password is None. But other than this it looks good to me. And also includes the Basic auth encoding fix in Pull #11. |
Is that actually possible/allowed and used anywhere? Authenticating with just a password? |
|
Yes, I personally have used username-less (just a password) authenticated JSON-RPC. |
|
@luke-jr looks like you need to fix some conflicts |
|
This isn't my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.