Lua image size #9343
Merged
Lua image size #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on suggestions by @cscheid. |
|
This looks fine to me -- do you want to make it a non-draft so I can merge it? My main reservation about such changes is just a general one -- it's more code that has to be changed if we ever change the ImageSize API. But if there are sufficient tests, we will be reminded about the need to make these changes if/when necessary. |
The module provides basic querying functions for image properties.
|
I've fixed the docs and added another test. Should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Lua module
pandoc.imagethat provides basic image querying functions.