Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not spam Created directory to stderr on each get_filename4code #109

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Felixoid
Copy link
Contributor

Hi. Each time the get_filename4code is called, it prints Created directory name, see timofurrer/pandoc-plantuml-filter#29 and timofurrer/pandoc-plantuml-filter#25

It will work as well, when the imagedir is symlink

In [3]: os.path.isdir('test-symlink')
Out[3]: True

In [6]: ls -l test-symlink
lrwxrwxrwx 1 felixoid felixoid 8 Jun 23 16:49 test-symlink -> examples/

@Felixoid
Copy link
Contributor Author

Felixoid commented Jun 23, 2024

I see it was changed in the 4da2c73

But now it's very noisy. The existing directory should be checked.

The job https://github.com/jgm/pandocfilters/actions/runs/9634327563/job/26569836419?pr=109 looks like some hick-up to me.

@Felixoid
Copy link
Contributor Author

Felixoid commented Jun 24, 2024

No, it's not a hick-up https://github.com/jgm/pandocfilters/actions/runs/9648939829/job/26611289299?pr=109

But it is something that needed to be addressed in the actions actions/setup-python#866

Specifically, actions/setup-python#866 (comment)

@jgm jgm merged commit 97bbee5 into jgm:master Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants