Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vars for tag.is-delete :hover/:focus/:active background color #3703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kikuomax
Copy link

@kikuomax kikuomax commented Dec 8, 2023

This is an improvement that will allow people to bind $background to CSS variables.

Proposed solution

Not a direct solution to but will help:

Tradeoffs

No tradeoffs.

Testing Done

  • 1. Pull the latest master branch
  • 2. Make sure your Sass code is compliant with the Bulma Sass styleguide
  • 3. Make sure your PR only affects .sass or documentation files
  • 4. Try your changes.

Additional check: No diffs in output css/bulma.css files before and after this change.

Changelog updated?

No.

- Introduces the following variables for tag:
    - `$tag-delete-background-color-focus`: background color for `tag`s
      with `is-delete` modifier when :hover or :focus
    - `$tag-delete-background-color-active`: background color for `tag`s
      with `is-delete` modifier when :active

  Introduction of the above variables will break nothing because their
  default bindings are the exact copies of those previously specified to
  `background-color` for :hover/:focus and :active respectively.

  This change will allow people to bind `$background` to CSS variables;
  e.g., jgthms#3694
@kikuomax kikuomax changed the title Add vars for tag.is-delete :hover/:focus/:active background Add vars for tag.is-delete :hover/:focus/:active background color Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant