Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade org.openapi.generator 7.7.0 #26675

Closed
wants to merge 1 commit into from

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jul 10, 2024

Fix #26615

Related to OpenAPITools/openapi-generator#18753


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert changed the title Upgrade org.openapi.generator from 7.7.0 Upgrade org.openapi.generator 7.7.0 Jul 10, 2024
@qmonmert qmonmert marked this pull request as ready for review July 10, 2024 20:44
@mshima
Copy link
Member

mshima commented Jul 11, 2024

We have removed buildscript block from gradle config, if possible we should avoid re-adding.
If necessary the build script should be optional on enableSwaggerCodegen.

@mshima
Copy link
Member

mshima commented Jul 12, 2024

Not needed anymore.
Gradle seems to use different dependency resolution with convention plugins.
The issue does not happen with convention plugins.
Thanks @qmonmert.

@mshima mshima closed this Jul 12, 2024
@mraible mraible added this to the 8.7.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants