Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to track function on entity list component template #27114

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

edilsonmendes
Copy link
Contributor

@edilsonmendes edilsonmendes commented Aug 29, 2024

Fix call to track function on entity list component template

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@kaidohallik
Copy link
Contributor

Thanks for the fix!

Can you do 3 more things with this PR:

  • remove redundant parameter _index from the tracking function in _entityFile_.component.ts.ejs (_entityFile_.component.spec.ts.ejs also needs change after that)
  • similar error is also in user-management.component.html.ejs - can you fix this issue also there
  • can you remove _index parameter also from the tracking function in user-management.component.ts.ejs

@kaidohallik
Copy link
Contributor

fixes #27112

@edilsonmendes
Copy link
Contributor Author

Thanks for the fix!

Can you do 3 more things with this PR:

  • remove redundant parameter _index from the tracking function in _entityFile_.component.ts.ejs (_entityFile_.component.spec.ts.ejs also needs change after that)
  • similar error is also in user-management.component.html.ejs - can you fix this issue also there
  • can you remove _index parameter also from the tracking function in user-management.component.ts.ejs

Sure. I'll adjust it.

@DanielFran DanielFran changed the title [27112]: Fix call to track function Fix call to track function Aug 29, 2024
@DanielFran DanielFran changed the title Fix call to track function Fix call to track function on entity list component template Aug 29, 2024
@kaidohallik kaidohallik merged commit ad17285 into jhipster:main Aug 29, 2024
39 checks passed
@kaidohallik
Copy link
Contributor

@edilsonmendes thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants