Browser min/max validation for dates and datetimes #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents people from selecting wrong date inputs in the first place. According to https://caniuse.com/input-datetime, workes on all browsers except Safari on iOS, but I've confirmed that adding the attributes doesn't change the behavior at all.
Simple changes, just needed to handle the different formatting functions.
|
Thanks, I didn't think that feature was compatible with the jQuery Validation Plugin but I was able to make some changes to the validation configuration to make it work (it seems to work, at least). It definitely makes the calendar widget more usable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents people from selecting wrong date inputs in the first place.
According to https://caniuse.com/input-datetime, works on all browsers except Safari on iOS, but I've confirmed that adding the attributes doesn't change the behavior on iOS, as we still have the necessary JS validation. Also tested on Firefox desktop and mobile.