QR fill #722
Merged
QR fill #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default makes the QR codes have a white background, so there is always enough contrast in dark mode for them to be useable.
Ensures that the link is still accessible to those without a separate phone and using a screen reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this PR to make QR codes a bit more accessible.
SvgPathFillImageclass instead ofSvgPathImage(both have been inqrcodefor a while, shouldn't be any version issues). My only other concern is that people might want the background to match the color of their off-white page, but IMO that group is smaller than those using the default light or dark themes. The fill is changeable with JS, changing thefillattribute of the<svg><rect>...tag.Pre-PR:
Post-PR: