-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use version released to Cocoapods and npm (#184)
Follow up to #166, now that has been released. Once this is landed, we should: 1. land anything that is to be in the next release. 2. do a release. We need to do a release now because: * The generated podspec file now includes a dependency on `uniffi-bindgen-react-native`. * We can remove pre-release caveats from the documentation.
- Loading branch information
Showing
7 changed files
with
22 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,27 @@ | ||
# Cutting a Release | ||
|
||
1. The version number should be incremented in the [`package.json`](https://github.com/jhugman/uniffi-bindgen-react-native/blob/main/package.json#L3) and the [`crates/ubrn_cli/Cargo.toml`](https://github.com/jhugman/uniffi-bindgen-react-native/blob/main/crates/ubrn_cli/Cargo.toml#L3). | ||
1. Push as a PR as usual, with subject: `Release ${VERSION_NUMBER}`. | ||
1. Once this has landed, [draft a new release](https://github.com/jhugman/uniffi-bindgen-react-native/releases/new). | ||
1. Create a new tag (in the choose a new tag dialog) with the version number (without a `v`). | ||
1. Use the version number again, but with a `v` prepended for the release title, `v${VERSION_NUMBER}`. | ||
1. Publish the release. | ||
1. Wait until the [Cocoapods](https://github.com/jhugman/uniffi-bindgen-react-native/actions/workflows/cocoapods.yml) and [NPM](https://github.com/jhugman/uniffi-bindgen-react-native/actions/workflows/npm.yml) publishing jobs are finished. | ||
1. Tell your friends, make a song and dance, you've done a new release. | ||
|
||
## Version numbers | ||
|
||
Uniffi has a `semver` versioning scheme. At time of writing, the current version of `uniffi-rs` is `0.28.3` | ||
|
||
`uniffi-bindgen-react-native` uses this version number with prepended with a `-` and a variant number, starting at `0`. | ||
|
||
Thus, at first release, the version of `uniffi-bindgen-react-native` will be `0.28.3-0`. | ||
Thus, at first release, the version of `uniffi-bindgen-react-native` was `0.28.3-0`. | ||
|
||
### Compatibility with other packages | ||
|
||
Other versioning we should take care to note: | ||
|
||
- React Native | ||
- `create-react-native-library` | ||
|
||
A version matrix is built during CI: [![version compatibility](https://github.com/jhugman/uniffi-bindgen-react-native/actions/workflows/compat.yml/badge.svg?query=branch%3Amain) compatibility matrix](https://github.com/jhugman/uniffi-bindgen-react-native/actions/workflows/compat.yml?query=branch%3Amain). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters