Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fixed filtering by producer/magazine on anime/manga search endpoints #528

Merged
merged 3 commits into from
May 29, 2024

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Apr 10, 2024

Fixes #517
Currently if you search by producer or magazine on anime/manga search endpoints respectively together with other filter parameters, you won't get back any results because the database query for the search was constructed incorrectly.
This PR fixes that problem.

Additional changes:

@pushrbx pushrbx requested a review from a team as a code owner April 10, 2024 18:07
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.76%. Comparing base (c425c32) to head (9342407).

Files Patch % Lines
app/Anime.php 50.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #528      +/-   ##
============================================
+ Coverage     57.45%   57.76%   +0.30%     
  Complexity     1352     1352              
============================================
  Files           339      339              
  Lines          5209     5209              
============================================
+ Hits           2993     3009      +16     
+ Misses         2216     2200      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfan-dahir irfan-dahir merged commit ce4bb92 into master May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 API Returns Empty Response When 'score' and 'producers' Parameters are Used Together
2 participants