-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed an issue with casting query string params on /top/reviews
endpoint
#549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
============================================
+ Coverage 57.66% 57.86% +0.19%
Complexity 1361 1361
============================================
Files 339 339
Lines 5270 5273 +3
============================================
+ Hits 3039 3051 +12
+ Misses 2231 2222 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pushrbx Sorry, completely missed this one.
LGTM - Added a small fix as the TopReviewsTypeEnum was being passed into jikan as an object rather the type value which was throwing an exception.
$requestParams->get
seems to be wrapping it back into an object - unsure why.
I'm going to fix the test errors before I merge. |
Fixes #548