Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce slug size by more than 2 times #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kenteltest
Copy link

  1. Reduce the size of the image by 30mb by preventing downloading and copying unnecessary .net runtime
  2. Reduce the size of the image by 2 times by removing unnecessary building artifacts (bin and obj dirs)

@jincod
Copy link
Owner

jincod commented Aug 29, 2022

Hello @kenteltest

Thank you for your contribution💪

I'll have a look at it

@jincod
Copy link
Owner

jincod commented Nov 5, 2022

Hello @kenteltest

Sorry for late answer.

I've checked the solution. It looks great.

I'm thinking about 3rd step: "move sources to src directory and delete this directory after publish"

If I understand correctly we reduce the slug size but we have to restore (download) nuget packages every time. So it affect the build time. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants