Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Make ColibriSession.relayId non-nullable (avoid use of !!). #1110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

squash: Remove leftover comment

9eaae83
Select commit
Loading
Failed to load commit list.
Open

ref: Make ColibriSession.relayId non-nullable (avoid use of !!). #1110

squash: Remove leftover comment
9eaae83
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Aug 21, 2023 in 0s

27.79% (-0.01%) compared to 42dd079

View this Pull Request on Codecov

27.79% (-0.01%) compared to 42dd079

Details

Codecov Report

Merging #1110 (9eaae83) into master (42dd079) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1110      +/-   ##
============================================
- Coverage     27.79%   27.79%   -0.01%     
  Complexity      494      494              
============================================
  Files           128      128              
  Lines          7760     7757       -3     
  Branches       1097     1097              
============================================
- Hits           2157     2156       -1     
+ Misses         5329     5326       -3     
- Partials        274      275       +1     
Files Changed Coverage Δ
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt 71.42% <0.00%> (-0.96%) ⬇️
...org/jitsi/jicofo/bridge/BridgeSelectionStrategy.kt 75.75% <0.00%> (ø)
...org/jitsi/jicofo/bridge/colibri/Colibri2Session.kt 0.00% <0.00%> (ø)
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt 0.00% <0.00%> (ø)
...src/main/kotlin/org/jitsi/jicofo/bridge/Cascade.kt 74.05% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dd079...9eaae83. Read the comment docs.