code review

jitsi · Oct 19, 2023 · a4013be · a4013be
1 parent 22ce5a5
commit a4013be
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/modules/API/API.js b/modules/API/API.js
@@ -993,12 +993,12 @@ function initCommands() {
             callback(isP2pActive(APP.store.getState()));
             break;
         }
-        case '_is_electron_screensharing': {
+        case '_new_electron_screensharing_supported': {
             callback(true);
             break;
         }
         default:
-            callback(null);
+            callback({ error: new Error('UnknownRequestError') });
 
             return false;
         }

diff --git a/modules/API/external/external_api.js b/modules/API/external/external_api.js
@@ -1279,9 +1279,9 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
      *
      * @returns {Promise}
      */
-    _isElectronScreensharing() {
+    _isNewElectronScreensharingSupported() {
         return this._transport.sendRequest({
-            name: '_is_electron_screensharing'
+            name: '_new_electron_screensharing_supported'
         });
     }
 

diff --git a/react/features/desktop-picker/functions.ts b/react/features/desktop-picker/functions.ts
@@ -15,6 +15,7 @@ import { ElectronWindowType } from './types';
 export function obtainDesktopSources(options: { thumbnailSize?: Object; types: string[]; }) {
     const { JitsiMeetElectron } = window as ElectronWindowType;
 
+    // TODO: delete this after 2 releases
     if (JitsiMeetElectron?.obtainDesktopStreams) {
         return new Promise((resolve, reject) => {
             JitsiMeetElectron.obtainDesktopStreams(