sdk(react-native-sdk): update script to check if dep versions are valid #13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Sep 20, 2023
saghul
requested changes
Sep 20, 2023
| console.log(` | ||
| ⚠️We changed ${key} version number from ${packageJSON.dependencies[key]} to ${RNSDKpackageJSON.peerDependencies[key]}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
You need to continue here. No point in doing more checks.
There was a problem hiding this comment.
But we need to update the version to a valid one, if that is the case, right?
There was a problem hiding this comment.
Yes, which you already do. I mean after doing that and logging the warning we can continue with the next item in the loop.
Calinteodor
force-pushed
the
rnsdk-script-update
branch
from
b075f58 to
31a59d8
Compare
saghul
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.