feat(authentication/native): hide login button for 8x8.vc #13881
Conversation
Calinteodor
changed the title
|
Why do we need to hide this only on native? If there is no other option, we should probably add a config and not hardcode domains, wdyt? |
| @@ -97,9 +106,11 @@ class WaitForOwnerDialog extends Component<IProps> { | |||
| */ | |||
| function mapStateToProps(state: IReduxState) { | |||
| const { membersOnly, lobbyWaitingForHost } = state['features/base/conference']; | |||
| const serverURL = getDefaultURL(state); | |||
There was a problem hiding this comment.
We don't want the default one, we need to check the current one.
There was a problem hiding this comment.
I was a bit confused because getDefaultURL returns getServerURL that returns the current one. Will update.
There was a problem hiding this comment.
Yes, but you can join a meeting in a server which is neither the default nor the configured one. We need to extract it from the current location URL.
| @@ -106,11 +107,12 @@ class WaitForOwnerDialog extends Component<IProps> { | |||
| */ | |||
| function mapStateToProps(state: IReduxState) { | |||
| const { membersOnly, lobbyWaitingForHost } = state['features/base/conference']; | |||
| const serverURL = getServerURL(state); | |||
| const { conference } = getConferenceState(state); | |||
| const locationURL = conference?.getConnection()[JITSI_CONNECTION_URL_KEY]; | |||
There was a problem hiding this comment.
Why don't you take it from sthe state? We store it in base/connection. Also, it's a URL, so you should compare the hostname part.
Calinteodor
force-pushed
the
hide-login-authentication
branch
from
f0caf8e to
6f5b2b0
Compare
| /** | ||
| * Location where the current meeting takes place. | ||
| */ | ||
| _hostname?: string; |
There was a problem hiding this comment.
Pl make this _confirmHidden and comput it in mapStateToProps instead.
No description provided.