dep(react-native): version 0.72.5 update #13897

Calinteodor · 2023-10-02T13:28:44Z

No description provided.

saghul

Some initial comments! Thanks for taking care of this!

.gitignore

ios/Podfile

package.json

patches/react-native+0.69.11.patch

Calinteodor · 2023-10-30T16:19:52Z

android/build.gradle

@@ -122,7 +129,7 @@ allprojects {
            project.version = "${json.version}-jitsi-${versionQualifierNumber}"

            task jitsiAndroidSourcesJar(type: Jar) {
-                classifier = 'sources'
+                archiveClassifier = 'sources'


classifier deprecated starting gradle 8.0

Let's drop the Gradle update, it's a major one and should be handled separately.

saghul

Some quick observations.

android/app/build.gradle

saghul · 2023-10-31T12:53:09Z

android/app/build.gradle

@@ -75,6 +76,9 @@ android {
 }

 dependencies {
+
+    // The version of react-native is set by the React Native Gradle Plugin
+    implementation('com.facebook.react:react-android')


Same as above, let's drop this for now, and reconsider later, but even if we end up using it, it would be in the SDK gradle, not the app.

saghul · 2023-10-31T12:53:17Z

android/app/build.gradle

@@ -173,5 +177,5 @@ gradle.projectsEvaluated {
 }

 if (googleServicesEnabled) {
-    apply plugin: 'com.google.gms.google-services'
+    apply plugin: "com.google.gms.google-services"


saghul · 2023-10-31T12:53:39Z

android/build.gradle

@@ -122,7 +129,7 @@ allprojects {
            project.version = "${json.version}-jitsi-${versionQualifierNumber}"

            task jitsiAndroidSourcesJar(type: Jar) {
-                classifier = 'sources'
+                archiveClassifier = 'sources'


Let's drop the Gradle update, it's a major one and should be handled separately.

saghul · 2023-10-31T12:55:17Z

ios/Podfile


 install! 'cocoapods', :deterministic_uuids => false

-production = ENV["PRODUCTION"] == "1"


What happened to this?

ios/Podfile

saghul · 2023-10-31T12:57:00Z

package.json

@@ -65,7 +66,7 @@
    "js-md5": "0.6.1",
    "js-sha512": "0.8.0",
    "jwt-decode": "2.2.0",
-    "lib-jitsi-meet": "https://github.com/jitsi/lib-jitsi-meet/releases/download/v1716.0.0+93c167d3/lib-jitsi-meet.tgz",
+    "lib-jitsi-meet": "https://github.com/jitsi/lib-jitsi-meet/releases/download/v1713.0.0+a1d7b0ea/lib-jitsi-meet.tgz",


Drop this change, ljm should not be downgraded.

saghul · 2023-10-31T12:57:23Z

package.json

-    "@babel/plugin-proposal-export-default-from": "7.16.0",
-    "@babel/preset-env": "7.16.0",
-    "@babel/preset-react": "7.16.0",
+    "@babel/core": "7.22.5",


IS this change absolutely necessary? If not I'd say we drop it to narrow down the scope.

I can test if it works without this update. It is recommended.

saghul · 2023-10-31T12:59:03Z

patches/react-native+0.72.6.patch

+-    if (!self->_inBackground && [RCTSharedApplication() applicationState] == UIApplicationStateBackground) {
+-      [self appDidMoveToBackground];
+-    }
+
 +  __block BOOL initialInBackground;
 +  dispatch_sync(dispatch_get_main_queue(), ^{


We need to update the patch here. They are alrey running the check on the main queue above, which is great. It just needs to include the check for the proximity state.

I submitted out patch upstream: facebook/react-native#41262 Perhaps you can just take that.

…file

Calinteodor · 2023-12-14T09:52:24Z

PR continues here #14130

Calinteodor marked this pull request as draft October 2, 2023 13:28

saghul reviewed Oct 2, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

ios/Podfile Outdated Show resolved Hide resolved

ios/Podfile Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

patches/react-native+0.69.11.patch Outdated Show resolved Hide resolved

Calinteodor force-pushed the rn-0.72.5-update branch 3 times, most recently from 3dd14e8 to 91b82d7 Compare October 9, 2023 06:59

Calinteodor force-pushed the rn-0.72.5-update branch from 91b82d7 to 6e39e45 Compare October 30, 2023 16:16

Calinteodor commented Oct 30, 2023

View reviewed changes

saghul requested changes Oct 31, 2023

View reviewed changes

Calinteodor force-pushed the rn-0.72.5-update branch from 333b53c to d030824 Compare November 7, 2023 13:50

Calinteodor added 21 commits November 13, 2023 12:43

dep(react-native): removed previous rn version patch and .buckconfig …

a8dfa06

…file

dep(react-native): required dependency updates

c8df8c4

dep(react-native/ios): fixed rebase conflict

2129809

dep(react-native/android): build.gradle updates

6ec4ec2

dep(react-native/android): build.gradle and gradle related updates

2de2335

dep(react-native/ios): Podfile updates

25c70d6

dep(react-native): changed metro configuration and added dependency

923e900

dep(react-native): native tsconfig update

29431b5

dep(react-native/ios): fixed another rebase conflict

fee1dc8

dep(react-native): removed caret and npm install

fab494c

dep(react-native/android): removed namespace from build.gradle

48ec414

dep(react-native): patch updated for 0.72.5

8c12610

dep(react-native): patch updated for 0.72.5 fix

b03b2e7

dep(react-native/ios): make platform depend on our own version

8b72e89

dep(react-native): react-native-gradle-plugin dep added

c5c0e9e

dep(react-native/ios): fixed rebase conflict and updated Podfile.lock

7cc0b74

dep(react-native): react-native-gradle-plugin removed

d8e4ed3

dep(react-native): revert types/react dep update

596cab7

ref(dependency/android): updates

664aa3a

ref(dependency/ios): podfile updates

077bbe3

ref(dependency): rn patch update and other

f873a18

Calinteodor added 4 commits November 13, 2023 12:43

ref(dependency/android): fixed some dep references

8acdc89

ref(dependency/android): revert maven change

61cba60

ref(react-native): review remarks

8c20910

ref(dependency): more rn-0.76 updates

f8a853e

Calinteodor force-pushed the rn-0.72.5-update branch from d030824 to f8a853e Compare November 13, 2023 10:44

Calinteodor closed this Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dep(react-native): version 0.72.5 update #13897

dep(react-native): version 0.72.5 update #13897

Calinteodor commented Oct 2, 2023

saghul left a comment

Calinteodor Oct 30, 2023

saghul Oct 31, 2023

saghul left a comment

saghul Oct 31, 2023

saghul Oct 31, 2023

saghul Oct 31, 2023

saghul Oct 31, 2023

saghul Oct 31, 2023

saghul Oct 31, 2023

Calinteodor Nov 6, 2023

saghul Oct 31, 2023

saghul Oct 31, 2023

Calinteodor commented Dec 14, 2023


		install! 'cocoapods', :deterministic_uuids => false

		production = ENV["PRODUCTION"] == "1"

dep(react-native): version 0.72.5 update #13897

dep(react-native): version 0.72.5 update #13897

Conversation

Calinteodor commented Oct 2, 2023

saghul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saghul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Calinteodor commented Dec 14, 2023