Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breakout-rooms/native): separate breakout rooms from participants #13920

Merged
merged 36 commits into from
Oct 11, 2023

Conversation

Calinteodor
Copy link
Contributor

No description provided.

@Calinteodor Calinteodor force-pushed the breakout-rooms-screen branch from 4951a63 to 4c49ee3 Compare October 9, 2023 06:32
@saghul
Copy link
Member

saghul commented Oct 9, 2023

Some UI feedback:

Screen Shot 2023-10-09 at 22 05 30

Let's put the button glued to the bottom.

Screen Shot 2023-10-09 at 22 05 02

No need to show the "Meeting participants (3)" thing and make it foldable. Remove it altogether unless there are entries in the lobby. Also put the participant count in the screen title please.

<FlatList

/* eslint-disable react/jsx-no-bind */
ListHeaderComponent = { () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@Calinteodor Calinteodor force-pushed the breakout-rooms-screen branch from 1d29cbe to a145456 Compare October 11, 2023 10:34
saghul
saghul previously approved these changes Oct 11, 2023
@Calinteodor Calinteodor merged commit 9c04ba7 into jitsi:master Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants