feat(prejoin): fix join meeting from external/calendar link while in another meeting #15310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinteodor
commented
Nov 18, 2024
Calinteodor
force-pushed
the
join-meeting-while-in-another-meeting
branch
from
3cbb052 to
69f43e9
Compare
saghul
reviewed
Nov 18, 2024
There was a problem hiding this comment.
I think the whole approach here is mcuh more complicated than it needs to be.
Where is the source of the problem, actually?
My hunch is that the Prejoin screen is cached, so not unmounted. As such, there is no code path that leads to calling setIsJoining(false); is there?
So what we really need is to reset that state. I think we have options for that. One could be when we navigate away, that is, after navigateRoot or perhaps when the component is blurred, but we do need to account for the warning screen. Another one is to do it when the room name changes, but there is a corner case when it doesn't, aka you try to join the same meeting.
Puttins this logic in the middleware is much more bug prone because we need to make sure all failure code paths cleanup.
Calinteodor
force-pushed
the
join-meeting-while-in-another-meeting
branch
from
bc87cd6 to
e24c397
Compare
saghul
approved these changes
Nov 18, 2024
Calinteodor
added a commit
that referenced
this pull request
Nov 18, 2024
…another meeting (#15310) If you are in meeting and you want to join another meeting from an external link, it is not possible. That is because Prejoin screen didn't get unmounted, isJoining remains true and button is unpressable. Most probably because react navigation, where the screen only gets focused or blurred.
iospro
pushed a commit
to iospro/jitsi-meet
that referenced
this pull request
Nov 22, 2024
…nfig * mobile-24.6: (367 commits) feat(prejoin): fix join meeting from external/calendar link while in another meeting (jitsi#15310) chore(apps, version): bump to 24.6.0 chore(sdk, version): bump to 10.3.0 fix(connection): Detects tenant hyphen and length problems and show notification. fix(connection): Shows notification instead of reload on conference request failed. feat(conference): revert fix for background app state (jitsi#15308) feat(tests): First test from torture to meet. (jitsi#15298) lang: update German translation chore(deps) lib-jitsi-meet@latest fix(local-recording) handle repeated values fix(ci) use macOS 15 to run iOS tests Update main-tr.json feat(reactions): Added heart reaction feat(ns) update Krisp to latest version feat(Video): Handle .play() errors. tr language updates fix(visitors): Fixes detection of turning of subtitles by visitor. fix(base/icons): error regarding default props fix(prejoin): Device indicator. chore(deps) lib-jitsi-meet@latest ... # Conflicts: # android/gradle.properties # android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetOngoingConferenceService.java # ios/app/broadcast-extension/Info.plist # ios/app/src/Info.plist # ios/app/watchos/app/Info.plist # ios/app/watchos/extension/Info.plist # ios/sdk/src/Info.plist # ios/sdk/src/Lite-Info.plist # react-native-sdk/package.json # react/features/keyboard-shortcuts/actions.web.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what was the reason behind that implementation, but I see no reason to keep it.
It breaks joining a meeting from external/calendar link while in another meeting.