feat(external_api) add function to toggle virtual background

[HannesOberreiter]

(closes old issue: #9399)

New API command to change the virtual background with a custom base64 image.

// Command
api.executeCommand('setVirtualBackground', false, 'data:image/png;base64, iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==');
// Function
api.setVirtualBackground(true, 'data:image/png;base64, iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==');

[jitsi-jenkins]

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

[damencho]

@saghul and @hristoterezov do we prefer functions or commands?

[pullrequest]

🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact or requires further evaluation. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request.

---

Check the status or cancel this secure code review here.

[saghul]

Given that the function is just a 1-liner that calls the command, so we really need it?

[pullrequest]

I don't have any security concerns with these changes.

Graham C

---

Reviewed with ❤️ by PullRequest

[HannesOberreiter]

My main reason for including the function was that it provides a convenient spot for JSDoc comments to explain its purpose. If we remove the function, we lose that explanation. Not sure if avoiding redundancy outweighs keeping the clarity.

[saghul]

That is a very good point. Let's keep it.

[saghul]

has the CLA been signed?

[HannesOberreiter]

Yes was earlier this year, company "certible".