Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config) add option to show recording link #15336

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config.js
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ var config = {
// // If true, shows a warning label in the prejoin screen to point out the possibility that
// // the call you're joining might be recorded.
// // showPrejoinWarning: true,
// // If true, the notification for recording start will display a link to download the cloud recording.
// // showRecordingLink: true,
// },

// recordingService: {
Expand Down
1 change: 1 addition & 0 deletions react/features/base/config/configType.ts
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ export interface IConfig {
recordings?: {
recordAudioAndVideo?: boolean;
showPrejoinWarning?: boolean;
showRecordingLink?: boolean;
suggestRecording?: boolean;
};
remoteVideoMenu?: {
Expand Down
2 changes: 2 additions & 0 deletions react/features/recording/actions.any.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export function showStartedRecordingNotification(
if (mode !== JitsiMeetJS.constants.recording.mode.STREAM) {
const recordingSharingUrl = getRecordingSharingUrl(state);
const iAmRecordingInitiator = getLocalParticipant(state)?.id === initiatorId;
const { showRecordingLink } = state['features/base/config'].recordings || {};

notifyProps.dialogProps = {
customActionHandler: undefined,
Expand All @@ -273,6 +274,7 @@ export function showStartedRecordingNotification(
if (recordingSharingUrl
&& isVpaasMeeting(state)
&& iAmRecordingInitiator
&& showRecordingLink
&& !isSavingRecordingOnDropbox(state)) {
const region = getMeetingRegion(state);
const tenant = getVpaasTenant(state);
Expand Down