Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transcript results from whisper may have json.language="zh-TW" a… #15338

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

shooding
Copy link
Contributor

transcript result from Whisper like:

{
    "transcript": [
        {
            "confidence": 1,
            "text": "大家好"
        }
    ],
    "is_interim": false,
    "language": "zh-TW",
    "message_id": "019368ee-0910-70c8-9b69-15b5d404551d",
    "event": "SPEECH",
    "type": "transcription-result",
    "participant": {
        "avatar_url": "https://www.gravatar.com/avatar/myavatarid?d=wavatar&size=200",
        "name": "韋智Chrome",
        "id": "1721a87f",
        "email": "me@gmail.com"
    },
    "stability": 1,
    "timestamp": 1732632250201
}

Current code only checks one direction.

…lso requesting transcriptions language could be "zh-CN". Use _getPrimaryLanguageCode func to compare only the main lang code.
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact or requires further evaluation. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request.


Check the status or cancel this secure code review here.

@saghul saghul requested a review from damencho November 27, 2024 08:20
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Graham C reviewed all the included code changes and associated automation findings and determined that there were no immediately actionable security flaws. Note that they will continue to be notified of any new commits or comments and follow up as needed throughout the duration of this pull request's lifecycle.

@saghul
Copy link
Member

saghul commented Dec 10, 2024

@damencho WDYT?

@damencho
Copy link
Member

Seems fine ... not sure 100% what is the value language ...

@saghul saghul merged commit 9d7237d into jitsi:master Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants