Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prosody): extend jigasi kick endpoint to work for any participant #15387

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

roanta2
Copy link
Contributor

@roanta2 roanta2 commented Dec 12, 2024

Extend jigasi kick endpoint to accept participantId param which allows for kicking any participant from a session.

@roanta2 roanta2 requested a review from damencho December 12, 2024 12:45
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rename this to mod_muc_kick_participant? It's no longer only about jigasi...

@@ -10,6 +10,7 @@ local formdecode = require "util.http".formdecode;
local urlencode = require "util.http".urlencode;
local jid = require "util.jid";
local json = require 'cjson.safe';
local split_jid = require "util.jid".split;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We jimport jid above, would it make sense to just call jid.split(...) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@damencho damencho merged commit 01a731a into master Dec 12, 2024
9 checks passed
@damencho damencho deleted the roanta/kick-participant-endpoint branch December 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants