Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(polls): Returns an error on duplicate poll. #15404

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(polls): Returns an error on duplicate poll. #15404

merged 1 commit into from
Dec 17, 2024

Conversation

damencho
Copy link
Member

No description provided.

@saghul
Copy link
Member

saghul commented Dec 17, 2024

Why don't we handle other errors like that?

@damencho
Copy link
Member Author

The problem was the return. By returning non nill, you basically ignore the message and it is not delivered.
What was happening is that the currently connected users were receiving the message and overriding their in memory state, while the new comers see the correct poll value which we did not replaced in prosody memory.

@damencho damencho merged commit 6bb984a into master Dec 17, 2024
10 checks passed
@damencho damencho deleted the fix-pols branch December 17, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damencho @saghul