ci: Add diff pipeline

jkroepke · Jul 21, 2024 · 11160d1 · 11160d1
1 parent 8cd4338
commit 11160d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml
@@ -52,7 +52,7 @@ jobs:
           changed=$(ct list-changed --config charts/ct.yaml)
           if [[ -n "$changed" ]]; then
             echo "changed=true" >> "$GITHUB_OUTPUT"
-            echo "changed_list=\"${changed//$'\n'/ }\"" >> "$GITHUB_OUTPUT"
+            echo "changed_list=\"${changed//$'\n'/ }\"" | tee -a "$GITHUB_OUTPUT"
           fi
 
       - name: install helm diff plugin
@@ -68,10 +68,14 @@ jobs:
       - name: Run chart-testing (diff)
         if: steps.list-changed.outputs.changed == 'true'
         run: |
-          changed_list=$(echo $changed_list)
           for chart in $changed_list; do
-            helm install $chart oci://ghcr.io/${{ github.repository_owner }}/charts/$chart --create-namespace --namespace $chart --wait
-            helm diff upgrade $chart charts/$chart \
+            echo "installing chart: $chart"
+            chart="${chart#*/}"
+
+            helm install --create-namespace --namespace "${chart}" --wait \
+              "${chart}" "oci://ghcr.io/${{ github.repository_owner }}/charts/$chart"
+
+            helm diff upgrade "${chart}" "charts/${chart}" \
               --namespace $chart \
               --suppress=CustomResourceDefinition \
               --normalize-manifests \

diff --git a/charts/github-actions-runner/templates/deployment.yaml b/charts/github-actions-runner/templates/deployment.yaml
@@ -45,7 +45,7 @@ spec:
             - "service"
           env:
           {{- range $key, $val := .Values.env }}
-            {{- if ne (eq $val "") }}
+            {{- if not (eq $val "") }}
             - name: {{ $key }}
               value: {{ $val | quote  }}
             {{- end }}