Fix "Add account" button and freeze issue #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a7a7de0): https://authleu--pr28-jlcvp-issue10-bsxpnh6w.web.app (expires Sat, 02 Nov 2024 20:30:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d2f3701b6fb9dc379d6dec3de8730502ef3b9864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues in the codebase. The first issue (#10) is related to the absence of an "Add account" button/link shortcut when the account list is empty. The second issue (#27) is related to the application freezing for 10 seconds after scanning a QR code.
The changes in this pull request include adding an "Add account" button/link shortcut when the account list is empty, and fixing the freeze issue by stopping the scanner when a QR code is scanned.
These changes address the reported issues and improve the user experience by providing a convenient way to add an account and preventing the application from freezing after scanning a QR code.
Fixes #10, #27