Allow accept header to be specified alongside profileURL #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have an endpoint I'd like to profile that returns HTML or JSON based on the accept header. By default it returns JSON but I'd like to provide a quick link via `profileURL` that will profile the HTML response instead. Since speedscope doesn't specify an accept header `fetch` defaults to `*/*` which ends up using the default value of that endpoint. I'd like to be able to specify the accept header explicitly so I can generate quick links to both JSON And HTML profiles. To solve that ask, this adds a new parameter to the hash based param logic, `profileAccepts`. This allows you to specify the accept header so that you can explicitly choose which content type to profile when using `#profileURL`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an endpoint I'd like to profile that returns HTML or JSON based on the accept header. By default it returns JSON but I'd like to provide a quick link via
profileURLthat will profile the HTML response instead.Since speedscope doesn't specify an accept header
fetchdefaults to*/*, which ends up using the default format of that endpoint. I'd like to be able to specify the accept header explicitly so I can generate quick links to both JSON And HTML profiles.To solve that ask, this adds a new parameter to the hash based param logic,
profileAccepts(better name suggestions welcome). This allows you to specify the accept header so that you can explicitly choose which content type to profile when using#profileURL.Usage:
https://speedscope.app/#profileURL=http://mywebsite/page-to-profile&#profileAccepts=application%2FjsonI didn't update the README or add any documentation, but happy to if requested!