Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD support #104

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add UMD support #104

wants to merge 4 commits into from

Conversation

JSteunou
Copy link

Hi,

I started a build umd branch to add AMD / CJS / Global support

Build is ok, have to add minify & clean up the src file to remove previous export and return Stomp object.

Also I was wondering if I could replace lib/stomp.js by the umd build instead of having to files, stomp.js & stomp.umd.js.

@JSteunou JSteunou changed the title Add build:umd (wip) Add UMD support Feb 19, 2015
@JSteunou
Copy link
Author

Done.

All working well, builds are ok, tests are ok

2 more things that can be done

  • build src file indentation is a little messed up because of the wrapper
  • cake tasks are launched immediately not waiting the end of the previous one (not broken since this PR, just working on this PR make me realise that), so cake build sometimes needs to be launch twice if you start with empty lib/ folder, because lib/stomp.js does not exist yet for the min or test task.

@JSteunou
Copy link
Author

still around @jmesnil ?

@JSteunou
Copy link
Author

I know you dont have much time but I'll really appreciate a review / merge from you @jmesnil ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant